-
Notifications
You must be signed in to change notification settings - Fork 8k
modules: lvgl: allow usage of zephyr memory-region for mem / vdb #96322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules: lvgl: allow usage of zephyr memory-region for mem / vdb #96322
Conversation
26534a2
to
42a773b
Compare
Partially updated without addition of choice for the time being. I will see for the choice / endchoice section, which will probably will make the PR bigger in order to also update existing Kconfig.default / conf files. |
This idea of this PR would be to avoid having to prepare linker scripts such as boards/st/stm32h747i_disco/dc_ram.ld, boards/st/stm32h757i_eval/dc_ram.ld, boards/st/stm32h7b3i_dk/dc_ram.ld for all boards, which also do not give flexibility on which section to use. |
42a773b
to
1df3b9f
Compare
Update following @JarmouniA proposal for config name and added depend !... to avoid possibility to have both mode enabled at the same time. I only put it on one side (ZEPHYR_REGION depends on !CUSTOM_SECTION) to avoid dependency loop. |
@erwango should I also remove the existing stm32 lvgl_buf related linker scripts and update the related conf to make usage of this new option instead ? |
+1 from me, since this should ensure it is built during CI and shows users looking for refrence usage how to do it. |
Yeah, go ahead. Let's clean this up right away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the others comments, LGTM.
@avolmat-st Please rebase to fix CI issue. |
a1d55c7
to
5a41008
Compare
Thanks @JarmouniA, updates applied. First push before rebase to be able to see updates. |
Allow selection of a custom section for memory-poll and / or VDB based on zephyr memory-regions. This takes advantages that zephyr,memory-region automatically have sections being created, hence allowing to easily indicate into which memory-region to store data. Signed-off-by: Alain Volmat <[email protected]>
Following introduction of LV_Z_MEMORY_POOL_ZEPHYR_REGION and LV_Z_VDB_ZEPHYR_REGION, remove the usage of the option LV_Z_VDB_CUSTOM_SECTION and the related linker scripts for STM32 boards & shields. Signed-off-by: Alain Volmat <[email protected]>
5a41008
to
d9f1a45
Compare
Thanks @erwango, now rebased. |
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
@faxe1008, could you have a look again ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please mention new Kconfig options in release notes
Allow selection of a custom section for memory-poll and / or VDB based on zephyr memory-regions.
This takes advantages that zephyr,memory-region automatically have sections being created, hence allowing to easily indicate into which memory-region to store data.